whekin/household-bot
1
0
Fork 0
mirror of https://github.com/whekin/household-bot.git synced 2026-03-31 15:44:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CI and PR review feedback

Browse Source 
Co-authored-by: claw <stanislavkalishin+claw@gmail.com>
This commit is contained in:
claw
2026-03-30 15:58:58 +02:00
parent 4d8d2fb6cf
commit ed2fbac284
10 changed files with 85 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/application/src/ad-hoc-notification-service.test.ts
View File

@@ -38,8 +38,8 @@ class NotificationRepositoryStub implements AdHocNotificationRepository {
sentAt: null,
cancelledAt: null,
cancelledByMemberId: null,
createdAt: Temporal.Instant.from('2026-03-23T09:00:00Z'),
updatedAt: Temporal.Instant.from('2026-03-23T09:00:00Z')
createdAt: Temporal.Instant.from('2099-03-23T09:00:00Z'),
updatedAt: Temporal.Instant.from('2099-03-23T09:00:00Z')
}
this.notifications.set(id, record)
return record
@@ -191,7 +191,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'Напомни Георгию завтра',
notificationText: 'пошпынять Георгия о том, позвонил ли он',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'topic'
})
@@ -222,7 +222,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'remind everyone tomorrow',
notificationText: 'pay rent',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'dm_all'
})
@@ -246,7 +246,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'remind tomorrow',
notificationText: 'check rent',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'topic',
friendlyTagAssignee: true
@@ -273,7 +273,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'remind tomorrow',
notificationText: 'call landlord',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'topic',
friendlyTagAssignee: false
@@ -282,7 +282,7 @@ describe('createAdHocNotificationService', () => {
const result = await service.cancelNotification({
notificationId: created.id,
viewerMemberId: 'admin',
asOf: Temporal.Instant.from('2026-03-23T09:00:00Z')
asOf: Temporal.Instant.from('2099-03-23T09:00:00Z')
})
expect(result.status).toBe('cancelled')
@@ -306,7 +306,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'remind tomorrow',
notificationText: 'call landlord',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'topic',
friendlyTagAssignee: false
@@ -315,7 +315,7 @@ describe('createAdHocNotificationService', () => {
const items = await service.listUpcomingNotifications({
householdId: 'household-1',
viewerMemberId: 'viewer',
asOf: Temporal.Instant.from('2026-03-23T09:00:00Z')
asOf: Temporal.Instant.from('2099-03-23T09:00:00Z')
})
expect(items).toHaveLength(1)
@@ -342,7 +342,7 @@ describe('createAdHocNotificationService', () => {
originalRequestText: 'remind tomorrow',
notificationText: 'call landlord',
timezone: 'Asia/Tbilisi',
scheduledFor: Temporal.Instant.from('2026-03-25T08:00:00Z'),
scheduledFor: Temporal.Instant.from('2099-03-25T08:00:00Z'),
timePrecision: 'date_only_defaulted',
deliveryMode: 'topic',
friendlyTagAssignee: false
@@ -355,7 +355,7 @@ describe('createAdHocNotificationService', () => {
timePrecision: 'exact',
deliveryMode: 'dm_selected',
dmRecipientMemberIds: ['alice', 'bob'],
asOf: Temporal.Instant.from('2026-03-23T09:00:00Z')
asOf: Temporal.Instant.from('2099-03-23T09:00:00Z')
})
expect(result.status).toBe('updated')

13
packages/application/src/scheduled-dispatch-service.ts
View File

@@ -8,6 +8,17 @@ import type {
} from '@household/ports'
const BUILT_IN_DISPATCH_KINDS = ['utilities', 'rent_warning', 'rent_due'] as const
const DEFAULT_DUE_DISPATCH_SCAN_LIMIT = 25
const MAX_DUE_DISPATCH_SCAN_LIMIT = 100
function normalizeDueDispatchLimit(limit: number | undefined): number {
const value = limit ?? DEFAULT_DUE_DISPATCH_SCAN_LIMIT
if (!Number.isInteger(value) || value <= 0) {
return DEFAULT_DUE_DISPATCH_SCAN_LIMIT
}
return Math.min(value, MAX_DUE_DISPATCH_SCAN_LIMIT)
}
function builtInDispatchDay(
kind: (typeof BUILT_IN_DISPATCH_KINDS)[number],
@@ -312,7 +323,7 @@ export function createScheduledDispatchService(input: {
return input.repository.listDueScheduledDispatches({
dueBefore: inputValue?.asOf ?? nowInstant(),
provider: input.scheduler.provider,
limit: inputValue?.limit ?? 25
limit: normalizeDueDispatchLimit(inputValue?.limit)
})
},